do not check every 5 seconds files with infinite timeout (= 0) #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we want to schedule a new sync attempt if a file is likely to have been unlocked due to timeout expiring on server but if the timeout is null (equal to 0), there will be no timeout on server and no automated unlocking, so do not schedule a sync every 5 seconds to check for it Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/nullTimeoutIsInfiniteDoNotCheckItEveryFiveSeconds
branch
from
1922371 to
a17b360
Compare
allexzander
approved these changes
Sep 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6059 +/- ##
==========================================
- Coverage 60.28% 60.24% -0.05%
==========================================
Files 145 145
Lines 18866 18868 +2
==========================================
- Hits 11374 11367 -7
- Misses 7492 7501 +9
|
|
Kudos, SonarCloud Quality Gate passed! |
|
/backport to stable-3.10 |
|
/backport to stable-3.9 |
|
AppImage file: nextcloud-PR-6059-a17b3608d93f503114880d4880584dcd0feee14f-x86_64.AppImage |
mgallien
deleted the
bugfix/nullTimeoutIsInfiniteDoNotCheckItEveryFiveSeconds
branch
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to schedule a new sync attempt if a file is likely to have been unlocked due to timeout expiring on server
but if the timeout is null (equal to 0), there will be no timeout on server and no automated unlocking, so do not schedule a sync every 5 seconds to check for it