-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/legacy migration #6072
Bugfix/legacy migration #6072
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6072 +/- ##
==========================================
- Coverage 60.33% 59.92% -0.42%
==========================================
Files 145 145
Lines 18800 18800
==========================================
- Hits 11343 11265 -78
- Misses 7457 7535 +78 |
Looks good generally :) some small points:
(decided to not show the detailed results of the import as it might be too long, if there is a way to show and hide the results then we could include it, but otherwise a simple confirmation is enough :) ) |
Perhaps the details could be put in an triangular collapsible text box? @camilasan also brought up idea of showing user names- I like this idea. Something simple like:
|
@privatemaker @nimishavijay @jancborchardt what do you think? |
9f00412
to
1f0b2fc
Compare
Looks good! 2 small changes that was missed with the previous feedback:
After that, it is super nice! :) |
Sadly I can't: |
520cd11
to
638f080
Compare
c39f569
to
fdb533a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise looks good
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
…mport. Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
…unt. Signed-off-by: Camila <hello@camila.codes>
…acyFolder Signed-off-by: Camila <hello@camila.codes>
…ction. Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
4d15236
to
d6eb5c5
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
AppImage file: nextcloud-PR-6072-d517cbfd687c70fa2123fad54eaa63d85993b52d-x86_64.AppImage |
/backport to stable-3.10 |
TODO
dialog 1:
dialog 2:
dialog when nothing was imported: