Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CaseConflictRecords search in local DB during the sync. #6083

Merged

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Sep 21, 2023

A bit of speed improvements for #4424

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #6083 (fde7933) into master (b3f3cff) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6083   +/-   ##
=======================================
  Coverage   60.32%   60.32%           
=======================================
  Files         145      145           
  Lines       18793    18800    +7     
=======================================
+ Hits        11337    11342    +5     
- Misses       7456     7458    +2     
Files Changed Coverage Δ
src/libsync/discoveryphase.h 20.00% <ø> (ø)
src/common/syncjournaldb.cpp 79.47% <66.66%> (-0.06%) ⬇️
src/libsync/discovery.cpp 86.43% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@allexzander allexzander force-pushed the feature/optimize-caseclashconflicts-search-during-sync branch from b3dbe6e to b614061 Compare September 22, 2023 15:20
Signed-off-by: alex-z <blackslayer4@gmail.com>
@mgallien mgallien force-pushed the feature/optimize-caseclashconflicts-search-during-sync branch from b614061 to fde7933 Compare September 25, 2023 08:37
@mgallien mgallien enabled auto-merge September 25, 2023 08:37
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6083-fde79335853bd0af443fb2cae5ce3a45d05c9223-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit a91c96b into master Sep 25, 2023
12 of 13 checks passed
@mgallien mgallien deleted the feature/optimize-caseclashconflicts-search-during-sync branch September 25, 2023 09:26
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants