-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to force end users to actively select a suitable local directory #7497
base: master
Are you sure you want to change the base?
Conversation
691fe9f
to
7339ba9
Compare
Thanks for trying to implement your feature request! ❤️
I am not sure if I follow your proposal.
I am not sure this is a good idea unless the user knows what they are doing. |
translations/client_fr.ts
Outdated
@@ -5981,7 +5981,7 @@ Le serveur a répondu avec l'erreur : %2</translation> | |||
<message> | |||
<location filename="../src/gui/wizard/welcomepage.cpp" line="70"/> | |||
<source>Easy-to-use web mail, calendaring & contacts</source> | |||
<translation>Courrier électronique, calendrier et contacts en ligne faciles à utiliser</translation> | |||
<translation>E-mail, agenda et contacts en ligne faciles à utiliser</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation files should not be changed, we pull them from Transifex: https://app.transifex.com/nextcloud/nextcloud/client/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to add a few more lines of code so that the general user gets the default folder as usual. Only in special cases do I want to force the user to manually select a folder without a default (or an institution-specific default).
src/gui/owncloudsetupwizard.cpp
Outdated
@@ -119,6 +119,7 @@ void OwncloudSetupWizard::startWizard() | |||
localFolder = QDir::homePath() + QLatin1Char('/') + localFolder; | |||
} | |||
|
|||
localFolder = "Please select folder"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see in line 119, localFolder is meant to be a path to a local folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to add a few more lines of code so that the general user gets the default folder as usual. Only in special cases do I want to force the user to manually select a folder without a default (or an institution-specific default).
I plan to add a few more lines of code so that the general user gets the default folder as usual. Only in special cases do I want to force the user to manually select a folder without a default (or an institution-specific default).
…--
This mail has been sent through the MPI for Demographic Research. Should you receive a mail that is apparently from a MPI user without this text displayed, then the address has most likely been faked. If you are uncertain about the validity of this message, please check the mail header or ask your system administrator for assistance.
|
In both cases Qt uses default system paths, each platform has one.
In our institution, we don't agree with the Qt default system paths (Windows OS). Of course, we try to teach our users to carefully select the local folder. But it would be helpful to have an option to turn off the defaults or change them to something else via an option.
…--
This mail has been sent through the MPI for Demographic Research. Should you receive a mail that is apparently from a MPI user without this text displayed, then the address has most likely been faked. If you are uncertain about the validity of this message, please check the mail header or ask your system administrator for assistance.
|
Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
add note on exclude file nextcloud#2917 Signed-off-by: Rello <Rello@users.noreply.github.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Co-authored-by: Camila Ayres <hello@camilasan.com> Signed-off-by: Rello <Rello@users.noreply.github.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Fabian Creutz <fabian.creutz@kaskadee.eu> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Camila Ayres <hello@camilasan.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Camila Ayres <hello@camilasan.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Camila Ayres <hello@camilasan.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
…ink. Signed-off-by: Camila Ayres <hello@camilasan.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Exit setupFavLink function when SHGetKnownFolderPath fails. Signed-off-by: Camila Ayres <hello@camilasan.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
We don't really need to have the check fo paletteSignalsConnected Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Theme may be instantiated before the qApp is available Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
This way we avoid the computation that happens in Theme::darkMode each time the property is accessed Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
should ensure comparisons of locale aware text is compared against locale aware test data will remove portability issues especially on Windows Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
ensure we report the expected availability erro for non existing files Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
will prevent truncating the modification time when changing the lock state of a file could be visible when using an office software to open an office file with automated locking happening after the file gets opened Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
tell tr that there is a number inside the translated string such that translators can provide the proper plural forms Changing text strings to correctly import them into Transifex. Issue nextcloud#3776. Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
we give them to APIs expecting int we compare them to int values Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
Signed-off-by: Rainer Walke <walke@demogr.mpg.de>
6b24b06
to
568e782
Compare
Feature description (see #7454)
When a user installs Nextcloud, the wizard uses a default directory that works.
Often, administrators do not recommend this folder as a local directory, e.g. in the Windows OS user's roaming profile.
The user should be required to actively select a local directory.
If the automatic software distribution could distribute an option like
proposeLocalDir=FALSE
to the nextcloud.cfg file,
the Nextcloud wizard would wait until the users themselves selected a suitable directory.
This would help administrators in organizations to promote a certain style of Nextcloud usage.
Nothing would change for individual Nextcloud users.
This is a first step to illustrate the idea.
The next step would be to read the nextcloud.cfg file and evaluate an additional option.