Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when updating a virtual file after lock/unlock: avoid setting modtime #7572

Merged

Conversation

mgallien
Copy link
Collaborator

will prevent truncating the modification time when changing the lock state of a file

could be visible when using an office software to open an office file with automated locking happening after the file gets opened

will prevent truncating the modification time when changing the lock
state of a file

could be visible when using an office software to open an office file
with automated locking happening after the file gets opened

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/doNotChangeModificationTimeWhenLockingOrUnlockingFiles branch from 5c08bd0 to 42cae2c Compare November 29, 2024 08:24
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7572-42cae2c5f1c02c63d3ff42c665c734dc6d0bedc1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 907b07c into master Nov 29, 2024
12 of 15 checks passed
@mgallien mgallien deleted the bugfix/doNotChangeModificationTimeWhenLockingOrUnlockingFiles branch November 29, 2024 10:09
@mgallien
Copy link
Collaborator Author

/backport to stable-3.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants