Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regressions in automated tests for bulk upload #7580

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien force-pushed the bugfix/fixAutomatedTestsOnWindows branch from 7ed68bf to 5916750 Compare November 27, 2024 16:56
@mgallien mgallien force-pushed the bugfix/fixAutomatedTestsOnWindows branch 2 times, most recently from c755142 to b88495b Compare November 28, 2024 10:57
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should ensure comparisons of locale aware text is compared against
locale aware test data

will remove portability issues especially on Windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
ensure we report the expected availability erro for non existing files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/fixAutomatedTestsOnWindows branch from c993a81 to 49267b8 Compare November 29, 2024 08:23
@mgallien mgallien merged commit 7a41a56 into master Nov 29, 2024
10 of 14 checks passed
@mgallien mgallien deleted the bugfix/fixAutomatedTestsOnWindows branch November 29, 2024 08:24
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7580-49267b894b9b7e1942fca8342d04d66c3dceeaaa-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator Author

/backport to stable-3.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants