Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Improves texts displayed to the user when picking the wrong location for syncing #7596

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

UI: Improves texts displayed to the user when picking the wrong location for syncing #7596

wants to merge 9 commits into from
+137 −64

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Dec 2, 2024 •
edited
Loading

⚠️ It depends on #7636 ⚠️

Improves texts displayed to the user when picking the wrong location for syncing:

  • User has no permissions to write to local folder:

noperms

  • The sync folder in the network:

network-location

  • Local folder does not exist:

doesnotexist

  • Trying to sync to the same folder locally:

double-sync

  • Folder contained in sync folder:

contained

  • Network drive/root:

drive2

  • Folder is already syncing to:

already-synced2

  • Root folder is already syncing:

root-synced

Rello
Rello reviewed Dec 3, 2024
View reviewed changes
src/common/vfs.cpp Outdated Show resolved Hide resolved
TheOneRing and others added 8 commits December 4, 2024 17:04
@TheOneRing @camilasan
Fix network drive detection
1fc0ec2 
We can't rely on the file system detection because Windows is reporting the underlying file system.

Fixes: #8272
@TheOneRing @camilasan
Fix crash on missing sync root
0f5e614 
Fixes: #9016
@TheOneRing @camilasan
Warn if we encounter an unsupported configuration
cf30443
@camilasan
Improve text returned when checking VFS availability.
66171f9 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve text when returning error on checking local path.
75fa5c4 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve error/warning text when adding sync folder.
ce5fb53 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve error strings when selecting remote folder.
0633f3f 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Modernize FolderWizardRemotePath::isComplete().
1db1c48 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Display the local folder path when warning that folder is already bei…
f57f894 
…ng synced.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan marked this pull request as ready for review December 4, 2024 21:42
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7596-f57f894fee3403f640a494ea57c6ddb3cd339d8c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan self-assigned this Dec 9, 2024
@camilasan camilasan added this to the 3.16.0 milestone Dec 10, 2024
@camilasan camilasan changed the title Bugfix network sync folder detection Improves texts displayed to the user when picking the wrong location for syncing Dec 11, 2024
@camilasan camilasan changed the title Improves texts displayed to the user when picking the wrong location for syncing UI: Improves texts displayed to the user when picking the wrong location for syncing Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rello Rello Rello left review comments

@claucambra claucambra Awaiting requested review from claucambra

@mgallien mgallien Awaiting requested review from mgallien

At least 1 approving review is required to merge this pull request.

Assignees

@camilasan camilasan

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@camilasan @nextcloud-desktop-bot @Rello @TheOneRing