Log path strings directly instead of accumulating #7718
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
reviewed
Jan 4, 2025
mgallien
requested changes
Jan 7, 2025
src/libsync/syncengine.cpp
Outdated
| }); | ||
|
|
||
| qCInfo(lcEngine()) << "paths to discover locally" << allPaths; | ||
| if (lcEngine().isInfoEnabled()) { |
There was a problem hiding this comment.
can you also add a check for _localDiscoveryPaths not being empty
|
Thanks for looking at this. I added the change. |
Signed-off-by: Felix <felix-git@0xf.eu>
Signed-off-by: Felix <felix-git@0xf.eu>
mgallien
force-pushed
the
improve-log-speed
branch
from
eeab13f to
5d9f4b8
Compare
mgallien
approved these changes
Jan 8, 2025
claucambra
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accumulating all discovery paths into one string causes major slowdowns: #7377
This fixes the issue by immediately writing the names out instead of accumulating them. Additionally a check is added to skip the loop entirely if logging is disabled for the given log level.