allow setting s3 concurrency, proxy, timeout, uploadPartSize, putSizeLimit, version, and verify_bucket_exists #2271
Conversation
jessebot
force-pushed
the
add-missing-s3-variables
branch
from
c355acb to
040b741
Compare
joshtrichards
added
enhancement
feature: auto config (environment variables)
README.md
Outdated
| - `OBJECTSTORE_S3_CONCURRENCY` (default: `5`) defines the maximum number of concurrent multipart uploads | ||
| - `OBJECTSTORE_S3_PROXY` (default: `false`) | ||
| - `OBJECTSTORE_S3_TIMEOUT` (default: `15`) | ||
| - `OBJECTSTORE_S3_UPLOADPARTSIZE` (default: `524288000`) | ||
| - `OBJECTSTORE_S3_PUTSIZELIMIT` (default: `104857600`) | ||
| - `OBJECTSTORE_S3_VERSION` (default: `latest`) | ||
| - `OBJECTSTORE_S3_VERIFY_BUCKET_EXISTS` (default: `true`) |
There was a problem hiding this comment.
do we also want to change these to "not set by default"? I can also understand keeping the defaults here, just so people don't have to cross reference with the nextcloud/server docs. Up to you, happy to accommodate either :)
There was a problem hiding this comment.
The provided config sets them to '' by default
There was a problem hiding this comment.
I did that because I was asked to back in September. I have now updated the docs to reflect that :)
There was a problem hiding this comment.
I'm not sure what the consequences are for any kind of S3 flavour if this is set to an empty string. Have you tested this somewhere?
There was a problem hiding this comment.
@jessebot I still have some doubts if an empty string overrides Nextcloud's defaults.
|
@joshtrichards wanted to gently follow up and ask if anything else is needed here? |
|
@J0WI or @joshtrichards can I ask if there's anything else needed here to get this merged into the default branch? Sorry to be a pest. I just want to make sure this gets merged so we can support it in the helm chart properly. |
jessebot
force-pushed
the
add-missing-s3-variables
branch
from
10d6edd to
2b545ea
Compare
…Limit, version, and verify_bucket_exists Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
jessebot
force-pushed
the
add-missing-s3-variables
branch
from
d7baf2f to
1581991
Compare
|
@joshtrichards or @J0WI could you take another look at this when you have a moment? |
Adds missing S3 related environment variables. Fixes #2270
Per the docs here's the missing supported S3 parameters:
concurrencydefaults to 5 [Note: This defines the maximum number of concurrent multipart uploads]proxydefaults to falsetimeoutdefaults to 15uploadPartSizedefaults to 524288000putSizeLimitdefaults to 104857600versiondefaults to latestverify_bucket_existsdefaults to true [Note: Setting this to false after confirming the bucket has been created may provide a performance benefit, but may not be possible in multibucket scenarios.]This also helps us get ready to merge nextcloud/helm#614 downstream 🙏
Let me know if you need anything else :)