Skip to content

Commit

Permalink
Merge pull request #12099 from nextcloud/marcoambrosini-patch-1
Browse files Browse the repository at this point in the history
Add clickable area and line height info
  • Loading branch information
marcoambrosini authored Aug 12, 2024
2 parents ac92790 + 6b07413 commit d027729
Showing 1 changed file with 20 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,26 @@ Capabilities
Front-end changes
-----------------

Clickable area
^^^^^^^^^^^^^^
The size of the CSS variable ``--clickable-area`` variable has shrunk from ``44px`` to ``34px``.
This will result in several regressions and paper-cuts in your app that will need to be manually fixed.
It's recommended to:

1) Link the @nextcloud/vue current master to your app (pull often cause fixes are getting in there too);
2) Do a codebase-wide search of `44px` and replace with the variable `--default-clickable-area` if appropriate;
3) Check for regressions and visual bugs;
4) Report the regression of your app in this issue (you can create a heading with the name of your own app);
5) Also report @nextlcoud/vue library regressions if they're not reported already in their list;
6) Fix regression in your app (only the ones that are unrelated to the @nextcloud/vue components);

Line height
^^^^^^^^^^^
The ``--default-line-height`` variable has changed from ``24px``` to ``1.5`` for the ``--default-font-size`` this
means that the actual value in pixel will go from 24 to 22.5. Although this is a slight change, it's recommended
to check for visual regressions in your app.


Font sizes
^^^^^^^^^^

Expand Down

0 comments on commit d027729

Please sign in to comment.