Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update talk_basics in user manual #11020

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 14, 2023

  • Added the filter conversations docs
  • Added the open conversations list docs
  • Updated outdated screenshots and/or their descriptions.

The screenshots have fixed widths because their sizes might appear larger than their actual dimensions when displayed.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the update_talk_basics_user_manual branch from 2bbc475 to 992cff5 Compare August 15, 2023 12:53
@DorraJaouad DorraJaouad marked this pull request as ready for review August 15, 2023 12:58
@DorraJaouad DorraJaouad self-assigned this Aug 15, 2023
user_manual/talk/images/new-room.png Outdated Show resolved Hide resolved
user_manual/talk/images/join-open-conversations.png Outdated Show resolved Hide resolved
user_manual/talk/images/devices-settings.png Outdated Show resolved Hide resolved
user_manual/talk/images/creating-open-conversation.png Outdated Show resolved Hide resolved
user_manual/talk/images/add-participants.png Outdated Show resolved Hide resolved
user_manual/talk/talk_basics.rst Outdated Show resolved Hide resolved
user_manual/talk/talk_basics.rst Outdated Show resolved Hide resolved
user_manual/talk/talk_basics.rst Show resolved Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad marked this pull request as draft August 16, 2023 09:23
@DorraJaouad DorraJaouad marked this pull request as ready for review August 16, 2023 09:44
@DorraJaouad DorraJaouad marked this pull request as draft August 16, 2023 09:45
Signed-off-by: Dorra <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the update_talk_basics_user_manual branch from 5668521 to 571fd51 Compare August 16, 2023 09:58
@DorraJaouad DorraJaouad marked this pull request as ready for review August 16, 2023 10:39
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor comments. Rest seems fine!

user_manual/talk/talk_basics.rst Outdated Show resolved Hide resolved
user_manual/talk/talk_basics.rst Outdated Show resolved Hide resolved
user_manual/talk/talk_basics.rst Outdated Show resolved Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 🎉

@DorraJaouad DorraJaouad merged commit 0b8dcd1 into master Aug 17, 2023
8 checks passed
@DorraJaouad DorraJaouad deleted the update_talk_basics_user_manual branch August 17, 2023 08:24
@welcome
Copy link

welcome bot commented Aug 17, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@DorraJaouad
Copy link
Contributor Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants