Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example_centos.rst for PHP8.2 #11191

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Update example_centos.rst for PHP8.2 #11191

merged 4 commits into from
Oct 17, 2023

Conversation

hellodarkness
Copy link
Contributor

@hellodarkness hellodarkness commented Oct 11, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

centos

@hellodarkness
Update example_centos.rst for PHP8.2
686f50f 
Signed-off-by: HelloDarkness <111370255+hellodarkness@users.noreply.github.com>
kesselb
kesselb requested changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

admin_manual/installation/example_centos.rst Outdated Show resolved Hide resolved
admin_manual/installation/example_centos.rst Outdated Show resolved Hide resolved
hellodarkness and others added 3 commits October 17, 2023 13:27
@hellodarkness @kesselb
Update admin_manual/installation/example_centos.rst
503cd23 
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: HelloDarkness <111370255+hellodarkness@users.noreply.github.com>
@hellodarkness @kesselb
Update admin_manual/installation/example_centos.rst
3c36284 
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: HelloDarkness <111370255+hellodarkness@users.noreply.github.com>
@hellodarkness
Merge branch 'master' into hellodarkness-centos
446683e
@hellodarkness
Copy link
Contributor Author

Thanks 👍

I'd originally kept php-cli separate as it's optional but fair point, your way is more concise!

@kesselb
Copy link
Contributor

kesselb commented Oct 17, 2023

php-cli separate as it's optional

You cannot use occ without, and therefore it's not really optional ;)

@kesselb kesselb merged commit 09cd3c2 into nextcloud:master Oct 17, 2023
8 checks passed
@welcome
Copy link

welcome bot commented Oct 17, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@kesselb
Copy link
Contributor

kesselb commented Oct 17, 2023

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update centos installation example
2 participants
@hellodarkness @kesselb