Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devmanual): WebDAV tags property name #11217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(devmanual): WebDAV tags property name #11217

wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

🖼️ Screenshots

image

@ChristophWurst
fix(devmanual): WebDAV tags property name
f51e792 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst self-assigned this Oct 16, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

nickvergessen
nickvergessen reviewed Oct 16, 2023
View reviewed changes
developer_manual/client_apis/WebDAV/basic.rst
@@ -201,7 +201,15 @@ Supported properties
| <nc:is-encrypted /> | Whether the folder is end-to-end encrypted. | | ``0`` for ``false`` |
| | | | ``1`` for ``true`` |
+-------------------------------+-------------------------------------------------+--------------------------------------------------------------------------------------+
| <oc:tags /> | List of user specified tags. | ``<oc:tag>test</oc:tag>`` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags still exist, that should be the favorite tag e.g.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

kesselb
kesselb approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Fine by me to keep or remove <oc:tags>.

You can also ask for favorite via <oc:favorite>.

@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@susnux
Copy link
Contributor

susnux commented Nov 12, 2024

So which way to go? Keep this PR (and rebase) or close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@kesselb kesselb kesselb approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review backport-request bug feature: dav feature: tags manual: developer
Projects
💌 📅 👥 Groupware team
Status: 🏗️ In progress
Milestone
Nextcloud 29.0.10
Development

Successfully merging this pull request may close these issues.
9 participants
@ChristophWurst @susnux @nickvergessen @kesselb @st3iny @joshtrichards @blizzz @Altahrim @skjnldsv