Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devmanual): Document contacts menu basics #11222

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat(devmanual): Document contacts menu basics #11222

merged 1 commit into from
Oct 18, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 17, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

Screenshot 2023-10-18 at 10-49-56 Contacts Menu — Nextcloud latest Developer Manual latest documentation

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone Oct 17, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 17, 2023
@ChristophWurst ChristophWurst mentioned this pull request Oct 17, 2023
Merged
8 tasks
christianlupus
christianlupus approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think, this looks good. I added some comments, that might be addressed ideally.

developer_manual/digging_deeper/groupware/contacts_menu.rst Outdated Show resolved Hide resolved
developer_manual/digging_deeper/groupware/contacts_menu.rst
Contacts Menu
=============

Nextcloud shows a *Contacts menu* in the right corner of the header. This menu lists a user's contacts. These contact entries can be extended by apps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An image (as an example might be nice here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of too many screenshots in the docs because they are getting outdated so fast and redoing all screenshots for a release is a lot of work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a suggestion. Feel free to resolve this comment.

@ChristophWurst
feat(devmanual): Document contacts menu basics
c7c3352 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst merged commit 8e13ded into master Oct 18, 2023
8 checks passed
@ChristophWurst ChristophWurst deleted the feat/devmanual/contacts-menu branch October 18, 2023 10:42
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst ChristophWurst mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianlupus christianlupus christianlupus approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review backport-request enhancement manual: developer
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @christianlupus