Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): Add useStrictDynamicOnScripts to OCP\AppFramework\Http\EmptyContentSecurityPolicy #11291

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(dev): Add useStrictDynamicOnScripts to OCP\AppFramework\Http\EmptyContentSecurityPolicy #11291

merged 1 commit into from
Nov 20, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 17, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

change log api
image image

@susnux susnux added this to the Nextcloud 28 milestone Nov 17, 2023
@susnux susnux mentioned this pull request Nov 17, 2023
Merged
4 tasks
ChristophWurst
ChristophWurst reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I may nitpick

#11282 (comment)

If there is existing CSP docs, please document this new feature there.

If there is no CSP docs start with the bare minimum.

🙏

@ChristophWurst
Copy link
Member

Good news: https://docs.nextcloud.com/server/latest/developer_manual/basics/controllers.html#modifying-the-content-security-policy

@susnux
Copy link
Contributor Author

susnux commented Nov 17, 2023

@ChristophWurst done ✔️

@susnux
fix(dev): Add useStrictDynamicOnScripts to `OCP\AppFramework\Http\E…
a32ee9d 
…mptyContentSecurityPolicy`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/csp-strict-dynamic branch from 08550ac to a32ee9d Compare November 17, 2023 17:29
@susnux susnux merged commit 895b42a into master Nov 20, 2023
8 checks passed
@susnux susnux deleted the fix/csp-strict-dynamic branch November 20, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review enhancement manual: developer
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @ChristophWurst @juliusknorr