Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uid is show on error messages instead of display name #250

Closed
small1 opened this issue Mar 14, 2024 · 2 comments · Fixed by #251
Closed

uid is show on error messages instead of display name #250

small1 opened this issue Mar 14, 2024 · 2 comments · Fixed by #251
Labels
bug Something isn't working

Comments

@small1
Copy link

small1 commented Mar 14, 2024 •
edited by susnux
Loading

When trying to open a locked file it shows uid in error message. See screenshot.

uuid

files_lock/lib/Controller/LockController.php

Line 153 in 545724d

$message = $this->l10n->t('File is currently locked by %s', [$lock->getOwner()]);

That should probably have something with displayname instead.
@come-nc come-nc added the bug Something isn't working label Mar 14, 2024
@juliusknorr juliusknorr mentioned this issue Mar 14, 2024
Merged
@Mika-6-9
Copy link

Mika-6-9 commented Mar 28, 2024 •
edited
Loading

Hi.
I no longer have the name in UID form displayed, but I have nothing displayed (we are in LDAP).
For me the subject is not closed.
Greetings.

Capture d'écran 2024-03-28 111156

P.S : The translation is ok

@Mika-6-9
Copy link

Hi.
Ok fix with #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use lock owner display name on error response nextcloud/files_lock
3 participants
@small1 @Mika-6-9 @come-nc