Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use lock owner display name on error response #251

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 14, 2024

Fix #250

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Mar 14, 2024
@susnux
Copy link
Contributor

susnux commented Mar 14, 2024

@juliushaertl do we backport?

@blizzz blizzz merged commit 4704039 into main Mar 14, 2024
44 checks passed
@blizzz blizzz deleted the fix/display-name-error-message branch March 14, 2024 12:37
@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

Copy link

backportbot bot commented Mar 15, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/251/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5acd287d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/251/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Mar 15, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/251/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5acd287d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/251/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor

susnux commented Mar 15, 2024

/backport to stable28

Copy link

backportbot bot commented Mar 15, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/251/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5acd287d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/251/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr
Copy link
Member Author

Needs a backport of #231 first

@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uid is show on error messages instead of display name
4 participants