Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow to unlock based on the current lock not the requested one to allow lock owners to unlock in any case #252

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: Allow to unlock based on the current lock not the requested one to allow lock owners to unlock in any case #252

merged 1 commit into from
Mar 15, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 14, 2024 •
edited
Loading

Steps to reproduce:

  • Share a folder from user A to user B
  • As user B:
    • Have a collabora file
    • Lock a file automatically by the client or lock it manually and fake the type to be 2 in the database
    • Try to unlock through the web UI

@juliusknorr
fix: Allow to unlock based on the current lock not the requested one …
85e5b80 
…to allow lock owners to unlock in any case

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Mar 14, 2024
blizzz
blizzz approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@juliusknorr juliusknorr merged commit 69990af into main Mar 15, 2024
44 checks passed
@juliusknorr juliusknorr deleted the fix/unlock-client-lock branch March 15, 2024 15:31
This was referenced Mar 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @blizzz