-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only update lock timeout when it is not infinite #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
Signed-off-by: Julius Härtl <jus@bitgrid.net>
be60b56
to
c5ec9cb
Compare
Hi @juliushaertl, |
When using open locally the desktop client will lock the file and send another lock request to extend once it is opened. This lead to the lock disappearing almost immediately after opening locally. |
/backport to stable29 |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/288/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c5ec9cbe
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/288/stable29 Error: Failed to clone repository: Failed to checkout branches: error: pathspec 'stable29' did not match any file(s) known to git Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable27 |
OK thanks |
Otherwise if the desktop client tries to refresh an infinite lock it will auto expire on the next check as it will be set to 1 second (
0 - (-1) - 0
)