Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare composer files for Nextcloud 30 #338

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Prepare composer files for Nextcloud 30 #338

merged 2 commits into from
Aug 13, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 13, 2024

  1. Nextcloud 30 is using PHP 8.1+, so bump PHP to 8.1
  2. Nextcloud 30 uses sabre/dav 4.6, so adjust the version (was already updated in the lock though)
  3. Pin other composer dev dependencies to the versions used in lock file

Also the info.xml was not correct, as the XSD says the dependencies MUST follow the screenshots and before background-jobs.

@susnux susnux requested a review from juliusknorr as a code owner August 13, 2024 17:45
@susnux susnux added dependencies Pull requests that update a dependency file 3. to review labels Aug 13, 2024
@susnux susnux added this to the Nextcloud 30 milestone Aug 13, 2024
susnux added 2 commits August 13, 2024 19:49
@susnux
chore: Update composer (PHP version and dependencies of NC30)
ecd9ae5 
* Nextcloud 30 uses PHP 8.1+
* Adjusted sabre/dav version used

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: info.xml was not following the XSD
48e92d0 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@juliusknorr juliusknorr merged commit 14ced48 into main Aug 13, 2024
43 checks passed
@juliusknorr juliusknorr deleted the nextcloud-30 branch August 13, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @juliusknorr