-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow force unlock of automated client locks #391
Merged
Merged
+2,202
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/unlock-app-lock
branch
from
November 15, 2024 09:36
9b79845
to
111d146
Compare
juliusknorr
changed the title
fix/unlock app lock
Allow force unlock of automated client locks
Nov 15, 2024
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
Will fix the conflict once I merged the remaining dependency updates on main |
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/unlock-app-lock
branch
from
November 18, 2024 13:51
a6dce61
to
f7eb95b
Compare
max-nextcloud
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look at the code. Did not test it though.
Signed-off-by: Julius Knorr <jus@bitgrid.net>
This was referenced Nov 27, 2024
3 tasks
When can we see a release with this? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure that lock owners can still unlock stale locks from clients that use the token type 2. We will show a confirmation dialog as revoking a lock could cause conflicts with file changes if the client comes back online assuming the lock would still be present.
Steps to test:
Replaces #172
Fix #325
UI changes