Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide zip menu item when there is no create permission in a folder #40

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 23, 2021

No description provided.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added the bug Something isn't working label Nov 23, 2021
@juliusknorr juliusknorr requested review from a team, artonge, skjnldsv and szaimen and removed request for a team November 23, 2021 08:23
@@ -29,6 +29,15 @@ import { showError, showSuccess } from '@nextcloud/dialogs'
).then(this.enhancePrompt.bind(this, suggestedFilename))
},
})

fileList.$el.on('urlChanged', data => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might be able to combine both permissions in a single string

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comment

Copy link

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl thanks for the fix! The thing is that I have actually create permissions in the folder I was trying to create the zip archive in. But the root folder itself is read only on my instance which probably triggered the issue although it should work in the directory I am in...
(see nextcloud/server#25787 where something like this happened to)

@juliusknorr
Copy link
Member Author

@juliushaertl thanks for the fix! The thing is that I have actually create permissions in the folder I was trying to create the zip archive in. But the root folder itself is read only on my instance which probably triggered the issue although it should work in the directory I am in...
(see nextcloud/server#25787 where something like this happened to)

Oh then let me double check the original issue, the PR makes sense nevertheless, I'll address the comment from Vincent

@juliusknorr
Copy link
Member Author

Lets get this in and follow up on the original ticket

@juliusknorr juliusknorr merged commit 9e00e00 into master Dec 29, 2021
@juliusknorr juliusknorr deleted the bugfix/39 branch December 29, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants