-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide zip menu item when there is no create permission in a folder #40
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@@ -29,6 +29,15 @@ import { showError, showSuccess } from '@nextcloud/dialogs' | |||
).then(this.enhancePrompt.bind(this, suggestedFilename)) | |||
}, | |||
}) | |||
|
|||
fileList.$el.on('urlChanged', data => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might be able to combine both permissions in a single string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 see minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliushaertl thanks for the fix! The thing is that I have actually create permissions in the folder I was trying to create the zip archive in. But the root folder itself is read only on my instance which probably triggered the issue although it should work in the directory I am in...
(see nextcloud/server#25787 where something like this happened to)
Oh then let me double check the original issue, the PR makes sense nevertheless, I'll address the comment from Vincent |
Lets get this in and follow up on the original ticket |
No description provided.