fix(AclStateButton): Increase contrast for inherited permissions

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud · Jul 18, 2024 · 8a225d7 · 8a225d7
1 parent 245ef9b
commit 8a225d7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/components/AclStateButton.vue b/src/components/AclStateButton.vue
@@ -157,5 +157,6 @@ export default {
 <style scoped>
 	.inherited {
 		opacity: 0.5;
+		color: var(--color-text-maxcontrast);
 	}
 </style>
diff --git a/src/components/SharingSidebarView.vue b/src/components/SharingSidebarView.vue
@@ -247,7 +247,11 @@ export default {
 					if (this.isNotInherited(permission, item.inheritedMask)) {
 						return inheritPermitted ? STATES.INHERIT_ALLOW : STATES.INHERIT_DENY
 					} else {
-						return STATES.INHERIT_DEFAULT
+						// return STATES.INHERIT_DEFAULT
+						// Inherited or not an action is either allowed or not allowed and it should be reflected
+						// Currently we different the permissions using contrast, using the max for inherited permisions
+						// WIP: Figure out how to properly check default permissions for group folders
+						return (permitted || inheritPermitted) ? STATES.INHERIT_ALLOW : STATES.INHERIT_DENY
 					}
 				}
 			}