Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass around preload rules in acl wrapper instead of relying on the cache #2560

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

icewind1991
Copy link
Member

Since the cache is intentionally limited in size (for memory reasons), it doesn't "work" for large folders or when you have a lot of groupfolders with acl enables.

This adds some more manual passing of preloaded rules around to avoid the need to rely on the generic cache in those cases.

@icewind1991 icewind1991 added the 3. to review Items that need to be reviewed label Sep 17, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Sep 17, 2023
@icewind1991
Copy link
Member Author

/backport to stable27

lib/ACL/ACLManager.php Outdated Show resolved Hide resolved
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

/backport to stable26

@icewind1991
Copy link
Member Author

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed backport-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants