Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump @nextcloud/files from 3.0.0-beta.11 to 3.0.0 #2614

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2023

Bumps @nextcloud/files from 3.0.0-beta.11 to 3.0.0.

Release notes

Sourced from @​nextcloud/files's releases.

v3.0.0

3.0.0 - 2023-11-08

Breaking

Enhancements

Fixed

... (truncated)

Changelog

Sourced from @​nextcloud/files's changelog.

3.0.0 - 2023-11-08

Breaking

Enhancements

Fixed

... (truncated)

Commits
  • ecb0b9e Merge pull request #827 from nextcloud-libraries/feat/3.0.0
  • 0d8c6e4 3.0.0
  • 69393a6 Merge pull request #821 from pulsejet/pulsejet/fix-dav
  • 4026d07 Merge pull request #826 from nextcloud-libraries/dependabot/npm_and_yarn/roll...
  • b152caf chore(deps-dev): Bump rollup from 4.1.4 to 4.3.0
  • a9c0e7d Merge pull request #825 from nextcloud-libraries/dependabot/npm_and_yarn/type...
  • b7dd656 Merge pull request #824 from nextcloud-libraries/dependabot/npm_and_yarn/type...
  • a426394 chore(deps-dev): Bump @​types/node from 20.8.9 to 20.8.10
  • d3cf3f8 chore(deps-dev): Bump typedoc from 0.25.2 to 0.25.3
  • 56de23a Merge pull request #823 from nextcloud-libraries/release/3.0.0-beta.27
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 11, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Bumps [@nextcloud/files](https://github.com/nextcloud-libraries/nextcloud-files) from 3.0.0-beta.11 to 3.0.0.
- [Release notes](https://github.com/nextcloud-libraries/nextcloud-files/releases)
- [Changelog](https://github.com/nextcloud-libraries/nextcloud-files/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-files@v3.0.0-beta.11...v3.0.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/files"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@artonge artonge force-pushed the dependabot/npm_and_yarn/nextcloud/files-3.0.0 branch from 96103a2 to f5886bc Compare November 28, 2023 16:33
@artonge
Copy link
Contributor

artonge commented Nov 28, 2023

/compile amend /

@artonge artonge enabled auto-merge November 28, 2023 16:33
@artonge
Copy link
Contributor

artonge commented Nov 28, 2023

@susnux or @icewind1991 Any idea why npm build fails? Especially errors like:

 ERROR in /home/runner/actions-runner/_work/groupfolders/groupfolders/src/settings/AdminGroupSelect.tsx
./src/settings/AdminGroupSelect.tsx 84:10-16
[tsl] ERROR in /home/runner/actions-runner/_work/groupfolders/groupfolders/src/settings/AdminGroupSelect.tsx(84,11)
      TS2786: 'Select' cannot be used as a JSX component.
  Its return type 'ReactElement<any, string | JSXElementConstructor<any>>' is not a valid JSX element.
 @ ./src/settings/App.tsx 137:0-50 341:156-172
 @ ./src/settings/index.tsx 3:0-28 13:9-12

I tried to tweak the dependencies, but with no success, and I don't see how the original updated dependencies could cause the failure.

@artonge
Copy link
Contributor

artonge commented Nov 28, 2023

FYI, I need this bump to use the new Files API in groupfolders.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…s with types from react 17

See also: vercel/next.js#42292

We need to update to react 18 to fix this properly

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor

susnux commented Nov 28, 2023

It looks like Typescript 5+ is required by the changed dependency, but the Types then do not work for React 17 when async components are used, so there is an error.
For the future a proper update to React 18 should solve this. But for now we can ignore that errors and fix the API changes from @nextcloud/files

@artonge artonge merged commit e997dbb into master Nov 28, 2023
9 checks passed
@artonge artonge deleted the dependabot/npm_and_yarn/nextcloud/files-3.0.0 branch November 28, 2023 17:45
@artonge
Copy link
Contributor

artonge commented Nov 28, 2023

/backport to stable28

@artonge
Copy link
Contributor

artonge commented Nov 29, 2023

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-request dependencies javascript Items related to Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants