Revert: don't apply acls when scanning #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
approved these changes
Feb 5, 2024
icewind1991
force-pushed
the
fix-encryption-scanner
branch
from
b77405d to
86f2efc
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
come-nc
force-pushed
the
fix-encryption-scanner
branch
from
86f2efc to
3c0463d
Compare
|
@icewind1991 This was not backported, it should be right? |
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage wrapper shenanigans break other wrappers like encryption
reverts: #2642
I've also tried to create a test case for the original "fix" but I can't seem to reproduce the issue anymore.