Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DavClient): Provide proper feedback for dav requests #3015

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jun 17, 2024

Before this commit there is no error handling whatsoever for this requests and the user won't get any visual feedback whatsoever irrespective of what goes down at the server level.

Resolves : https://github.com/nextcloud-gmbh/customer-feature-requests/issues/796

Before After
Screenshot from 2024-07-02 16-47-17 Screenshot from 2024-07-02 16-21-24

TODO

  • Use Nextcloud logger?
  • Toast for success necessary?
  • Before and after demo

@nfebe nfebe added 2. developing Items that are currently under development 3. to review Items that need to be reviewed labels Jun 17, 2024
@nfebe nfebe force-pushed the fix/acl/add-visual-feedback-on-failure-success branch from 812e4e3 to c29312b Compare June 17, 2024 23:26
@nfebe nfebe force-pushed the fix/acl/add-visual-feedback-on-failure-success branch 2 times, most recently from 9cc07b0 to 072e1a8 Compare July 2, 2024 15:25
@nfebe nfebe marked this pull request as ready for review July 2, 2024 15:48
@nfebe nfebe requested review from artonge, Pytal, sorbaugh and skjnldsv July 2, 2024 15:48
@nfebe nfebe added feature: acl Items related to the groupfolders ACL or "Advanced Permissions" and removed 2. developing Items that are currently under development labels Jul 2, 2024
src/client.js Outdated Show resolved Hide resolved
@nfebe nfebe force-pushed the fix/acl/add-visual-feedback-on-failure-success branch from 5cb5987 to 5cd2787 Compare July 3, 2024 10:34
@nfebe nfebe requested a review from skjnldsv July 3, 2024 10:35
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the mixed space-tabs indents

@nfebe nfebe force-pushed the fix/acl/add-visual-feedback-on-failure-success branch from 5cd2787 to f9b1b19 Compare July 4, 2024 14:58
@nfebe nfebe requested a review from artonge July 4, 2024 14:59
nfebe added 2 commits July 4, 2024 15:59
Before this commit there is no error handling whatsover for this requests and
the user won't get any visual feedback whatsover irrespective of what goes down
at the server level.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the fix/acl/add-visual-feedback-on-failure-success branch from f9b1b19 to b03954e Compare July 4, 2024 15:00
@nfebe
Copy link
Contributor Author

nfebe commented Jul 5, 2024

Cypress tests failures unrelated.

@nfebe nfebe merged commit 243e0ec into master Jul 5, 2024
42 of 44 checks passed
@nfebe nfebe deleted the fix/acl/add-visual-feedback-on-failure-success branch July 5, 2024 08:41
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed feature: acl Items related to the groupfolders ACL or "Advanced Permissions" feedback-requested
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants