Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if array key exists #3042

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix: check if array key exists #3042

merged 2 commits into from
Jul 12, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jul 5, 2024

Fix #2952

@solracsf solracsf added the 3. to review Items that need to be reviewed label Jul 5, 2024
@solracsf
fix: check if array key exists
a527567 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf requested review from icewind1991 and come-nc July 10, 2024 07:17
come-nc
come-nc approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement suggestion but otherwise good

lib/Controller/FolderController.php Outdated Show resolved Hide resolved
@solracsf @come-nc
chore: small optimization
9c481bf 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf requested a review from artonge July 11, 2024 13:17
@solracsf solracsf merged commit f9b8f1e into master Jul 12, 2024
37 of 40 checks passed
@solracsf solracsf deleted the checkArrayKey branch July 12, 2024 09:32
@solracsf
Copy link
Member Author

/backport to stable29

@solracsf
Copy link
Member Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jul 12, 2024
Merged
@backportbot backportbot bot mentioned this pull request Jul 12, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@artonge artonge artonge approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined array key "group_details"
3 participants
@solracsf @artonge @come-nc