Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] don't error if we can't find a trashbin item for a file when looking … #3074

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 21, 2024

Backport of PR #2813

@backportbot backportbot bot requested review from come-nc and icewind1991 July 21, 2024 19:22
@backportbot backportbot bot added the 3. to review Items that need to be reviewed label Jul 21, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.1 milestone Jul 21, 2024
@skjnldsv skjnldsv force-pushed the backport/2813/stable28 branch from aaf0f2c to 5e73f4a Compare August 28, 2024 12:01
@skjnldsv
Copy link
Member

Related

1) OCA\groupfolders\tests\ACL\ACLManagerTest::testGetACLPermissionsForPathNoRules
TypeError: OCA\GroupFolders\ACL\ACLManager::__construct(): Argument #3 ($logger) must be of type Psr\Log\LoggerInterface, Mock_IUser_b64e9d67 given, called in /home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/tests/ACL/ACLManagerTest.php on line 88

/home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/lib/ACL/ACLManager.php:38
/home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/tests/ACL/ACLManagerTest.php:88
/home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/tests/ACL/ACLManagerTest.php:57

@skjnldsv skjnldsv added bug 2. developing Items that are currently under development and removed 3. to review Items that need to be reviewed labels Aug 28, 2024
@solracsf
Copy link
Member

@skjnldsv tests need to be fixed too. Backport #3043 ?

@skjnldsv skjnldsv enabled auto-merge August 30, 2024 09:00
@skjnldsv skjnldsv disabled auto-merge August 30, 2024 09:00
icewind1991 and others added 3 commits August 30, 2024 11:08
…for relevant acl paths

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

chore: optimize code

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: call logger

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Add LoggerInterface

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Fix: Typo

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the backport/2813/stable28 branch from d6e552f to 69f808d Compare August 30, 2024 09:08
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 8b42117 into stable28 Aug 30, 2024
11 of 14 checks passed
@skjnldsv skjnldsv deleted the backport/2813/stable28 branch August 30, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Items that are currently under development bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants