Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Save deleted by property #3170

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat: Save deleted by property #3170

merged 1 commit into from
Sep 9, 2024

Conversation

@artonge artonge self-assigned this Sep 5, 2024
@artonge artonge requested review from come-nc and Pytal September 5, 2024 19:41
@artonge artonge added 3. to review Items that need to be reviewed php Items related to PHP updates and code issues feature: trashbin Items related to the trashbin feature enhancement labels Sep 5, 2024
@artonge
Copy link
Contributor Author

artonge commented Sep 5, 2024

/backport to stable30

@Pytal
Copy link
Member

Pytal commented Sep 5, 2024

Tested and am getting "Delete file" action failed 🤔

CI is also not happy

@Pytal
Copy link
Member

Pytal commented Sep 5, 2024

Had to run the migration manually and delete worked but is not showing in trashbin

Version needs to be bumped to trigger it

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, did not test.

@artonge artonge force-pushed the artonge/feat/deleted_by branch 2 times, most recently from b179fb9 to 3cb0afe Compare September 9, 2024 12:31
@artonge artonge requested a review from icewind1991 as a code owner September 9, 2024 12:31
@artonge artonge force-pushed the artonge/feat/deleted_by branch 2 times, most recently from f17a071 to 29e3c14 Compare September 9, 2024 13:29
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/deleted_by branch from 29e3c14 to e11fff0 Compare September 9, 2024 13:34
@artonge artonge merged commit 2c8f72c into master Sep 9, 2024
43 checks passed
@artonge artonge deleted the artonge/feat/deleted_by branch September 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed enhancement feature: trashbin Items related to the trashbin feature php Items related to PHP updates and code issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Files deleted in group folders are deleted by “unknown”
3 participants