Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 3130 : missing translations for Transifex #3191

Conversation

smarinier
Copy link
Contributor

Simply move the backticks to a string concatenation

Signed-off-by: Sebastien Marinier <seb@smarinier.net>
@provokateurin
Copy link
Member

Thank you @smarinier, can I somehow verify the changes work?

@smarinier
Copy link
Contributor Author

Thank you @smarinier, can I somehow verify the changes work?

Ah. It's quite complicated, as this change operates lately with the translationtool automatic action, once the PR is merged. With BBB Integration, we saw this happening some days after. I have not idea of when nor how translationtool is precisely started. (May be @joshtrichards ?).
Otherwise, you may launch manually translationtool on groupfolder folder, and watch the changes on pot files, with or without the PR.

@provokateurin
Copy link
Member

Ok I will give it a try.

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I was able to confirm it works as expected!

@provokateurin
Copy link
Member

/backport to stable30

@provokateurin
Copy link
Member

/backport to stable29

@provokateurin
Copy link
Member

/backport to stable28

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many wordings have never been translated because they're not in Transifex
4 participants