Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(settings): Use Promise for API requests #3200

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

provokateurin
Copy link
Member

Also drops all references to JQuery ;)

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added the 3. to review Items that need to be reviewed label Sep 10, 2024
@provokateurin provokateurin changed the title fix(settings): Use correct type for ACL mapping search results refactor(settings): Use Promise for API requests Sep 10, 2024
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the refactor/settings/promise branch from cdb0455 to edd8e10 Compare September 10, 2024 15:04
@artonge
Copy link
Contributor

artonge commented Sep 10, 2024

Also drops all references to JQuery ;)

Not true ;)

@provokateurin
Copy link
Member Author

Not true ;)

Huh where is it still used/referenced?

@provokateurin provokateurin merged commit 91c7662 into master Sep 10, 2024
45 checks passed
@provokateurin provokateurin deleted the refactor/settings/promise branch September 10, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants