Allow probe checks and Service to use containerPort if specified #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For non-root deployments (such as required in OpenShift), this makes the given containerPort be used instead of hardcoding to "http" in several places. Signed-off-by: Rick Elrod <rick@elrod.me>
relrod
changed the title
3 tasks
jessebot
reviewed
Apr 24, 2023
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| name: nextcloud | |||
| version: 3.3.3 | |||
| version: 3.3.4 | |||
There was a problem hiding this comment.
need to bump chart version
|
This was done in a215de8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Note: This probably can and should fold into #278.
This allows
containerPortto be used for the readiness/startup/liveness probes along with thetargetPortof the Service, otherwise they default to 80 and fail if the httpd inside the container is listening on another port.This is particularly important on OpenShift where by default you cannot access privileged ports.
Benefits
Makes it easier for OpenShift users? :)
Possible drawbacks
There should not be any - the old default is kept if
containerPortisn't defined.Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.