Fix postgresql-isready image - adds postgresql.image.registry from values.yaml

[schmittvictor]

Pull Request

Description of the change

Fix postgresql-isready image

Benefits

Possible drawbacks

Applicable issues

• fixes postgresql image tags not iso for pods "postgresql-isready" and "postgresql" #468

Additional information

Checklist

• DCO has been signed off on the commit.
• Chart version bumped in Chart.yaml according to semver.
• (optional) Variables are documented in the README.md

[jessebot]

Could you please make sure to document this option in the readme under this section?
https://github.com/nextcloud/helm/tree/main/charts/nextcloud#database-configurations

[jessebot]

@schmittvictor could you please answer @provokateurin's question and also resolve the conflicts?

[MaximUltimatum]

I attempted to push the fix to this PR, but I don't have access rights. (Did test out the linting tool mentioned in the open Contributing doc update though, which is rad). Regardless, @schmittvictor you should be able to pull in the default strategy used here https://github.com/nextcloud/helm/pull/262/files, per @jessebot 's earlier comment to satisfy @provokateurin 's concern

[schmittvictor]

I resolved the conflicts, I think you can approve

[provokateurin]

@schmittvictor Would it be possible for you to also fix this for all the other images we use? You can easily search for .image.repository. I found that the mariadb-isalive initcontainer already handles the registry, but not with the fallback (which should be fixed as well).

[jessebot]

Suggested change

	image: {{ .Values.postgresql.image.registry | default "docker.io" }}/{{ .Values.postgresql.image.repository }}:{{ .Values.postgresql.image.tag }}
	image: {{ template "postgresql.v1.image" .Subcharts.postgresql }}

We could also do this now that I think about it, which is less wordy. It templates this:

https://github.com/bitnami/charts/blob/0fa3d414009575ed81ff876fd883338afac1ee77/bitnami/postgresql/templates/_helpers.tpl#L44-L49

Which does all the fancy logic here:
https://github.com/bitnami/charts/blob/0fa3d414009575ed81ff876fd883338afac1ee77/bitnami/common/templates/_images.tpl#L6-L30

[jessebot]

@schmittvictor Would it be possible for you to also fix this for all the other images we use? You can easily search for .image.repository. I found that the mariadb-isalive initcontainer already handles the registry, but not with the fallback (which should be fixed as well).

To move this foward, as this would also close #262, which is one of our oldest PRs, how about we merge this, and then I can create another PR to do mariadb?

[provokateurin]

Sure. I think we shouldn't go with your suggestion of letting the subcharts handle this. Otherwise we will have even more diverging logic for the images.

[jessebot]

that seems fine to me :) I was just trying to reduce code as they've already written the handlers here, but I'm not married to this at all. I'll merge this and then create a new PR for mariadb