Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for immutable image #496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thefirstofthe300
Copy link

Pull Request

Description of the change

Nextcloud is capable of being built using an immutable image (see https://github.com/thefirstofthe300/nextcloud-docker). In this scenario, there is no point in mounting the /var/www and /var/www/html directories to store state. The remaining directories should be mounted, but not these two.

Benefits

Allows users to build their own immutable images which do not perform an rsync on start but still use this chart.

Possible drawbacks

The default values are not changing so I see no drawbacks.

Additional information

Signed-off-by: Danny Seymour <danny@seymour.family>
@jessebot
Copy link
Collaborator

jessebot commented Apr 9, 2024

Does anything bad happen if those volumes are mounted anyway? It looks like you linked a custom image, which you can absolutely use, but I'm unsure if we support this. Either way, the branch needs to be rebased.

@provokateurin are you aware of an immutable mode for nextcloud? I don't really see any issues with merging this, but I also don't have a quick way to test it.

@provokateurin
Copy link
Member

Nextcloud is not really immutable. It will probably run into quite a few issues because all code assumes the whole dir is writable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants