Enable setting initContainers' resources #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds values that lets users set the resources (requests/limits) for the initContainers in the nextcloud pod. I did also did a small refactoring to keep the code simple and also added the missing `securityContext` values to the README. Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change adds values that lets users set the resources (requests/limits) for the initContainers in the nextcloud pod.
I did also did a small refactoring to keep the code simple and also added the missing
securityContextvalues to the README.Benefits
By setting resource requests for the
initContainers, many different failure modes can be avoided.Possible drawbacks
Increased code complexity, maybe.
Applicable issues
Additional information
See #661
Checklist
Chart.yamlaccording to semver.