feat: apply personal out-of-office data to the auto responder #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
force-pushed
the
feat/ooo-auto-responder-integration
branch
2 times, most recently
from
a5fe9c2 to
f1afc7d
Compare
|
Psalm is still not happy |
|
/backport to stable3.5 |
| } | ||
|
|
||
| public function handle(Event $event): void { | ||
| if (!($event instanceof OutOfOfficeStartedEvent) && !($event instanceof OutOfOfficeEndedEvent)) { |
There was a problem hiding this comment.
currently not covered: ooo changed event. listening to that would allow Mail to reflect changes to the ooo message when ooo is ongoing
There was a problem hiding this comment.
the current feature set is fine for an mvp. we can add change propagation later.
|
OCP packages were outdated. Psalm passes now after rerun. |
ChristophWurst
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Tested & works
It's also super nice to see that the same account configured on an installation of this branch is compatible with a 3.5.0rc1 installation. The other installation still recognizes the autoresponder as enabled with the data set from the new automation.
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
feat/ooo-auto-responder-integration
branch
from
6f8c0fb to
3cbdf1f
Compare
|
/backport to stable3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8925
Requires nextcloud/server#41440
I had to move the sieve "parser" to the backend. There should be no regressions and it should behave exactly like before. Proof: I moved all tests and test data to the backend and they all pass without modifications.
Note: This PR looks huge but to be fair there are a lot of tests and test data.
TODO