Merge pull request #731 from nextcloud/feature/precompile-all-svgs

Feature/precompile all svgs

packages/app/lib/branding.dart

@@ -1,19 +1,21 @@
 import 'dart:ui';
 
-import 'package:flutter_svg/flutter_svg.dart';
 import 'package:neon/theme.dart';
+import 'package:vector_graphics/vector_graphics.dart';
 
-final neonTheme = NeonTheme(
+const neonTheme = NeonTheme(
   branding: branding,
   colorScheme: colorScheme,
 );
 
-final branding = Branding(
+const branding = Branding(
   name: 'Nextcloud Neon',
-  logo: SvgPicture.asset(
-    'assets/logo.svg',
+  logo: VectorGraphic(
     width: 100,
     height: 100,
+    loader: AssetBytesLoader(
+      'assets/logo.svg.vec',
+    ),
   ),
   legalese: 'Copyright © 2023, provokateurin\nUnder GPLv3 license',
 );

packages/app/pubspec.lock

@@ -367,7 +367,7 @@ packages:
     source: hosted
     version: "2.0.16"
   flutter_svg:
-    dependency: "direct main"
+    dependency: transitive
     description:
       name: flutter_svg
       sha256: "8c5d68a82add3ca76d792f058b186a0599414f279f00ece4830b9b231b570338"
@@ -1232,7 +1232,7 @@ packages:
     source: hosted
     version: "3.0.7"
   vector_graphics:
-    dependency: transitive
+    dependency: "direct main"
     description:
       name: vector_graphics
       sha256: "670f6e07aca990b4a2bcdc08a784193c4ccdd1932620244c3a86bb72a0eac67f"

packages/app/pubspec.yaml

@@ -9,7 +9,6 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  flutter_svg: ^2.0.7
   neon:
     git:
       url: https://github.com/nextcloud/neon
@@ -30,6 +29,7 @@ dependencies:
     git:
       url: https://github.com/nextcloud/neon
       path: packages/neon/neon_notifications
+  vector_graphics: ^1.1.7
 
 dev_dependencies:
   flutter_material_design_icons: ^1.1.7296

packages/neon/neon/lib/src/models/app_implementation.dart

@@ -1,6 +1,5 @@
 import 'package:collection/collection.dart';
 import 'package:flutter/material.dart';
-import 'package:flutter_svg/flutter_svg.dart';
 import 'package:go_router/go_router.dart';
 import 'package:meta/meta.dart';
 import 'package:neon/l10n/localizations.dart';
@@ -12,6 +11,7 @@ import 'package:neon/src/settings/models/storage.dart';
 import 'package:neon/src/widgets/drawer_destination.dart';
 import 'package:provider/provider.dart';
 import 'package:rxdart/rxdart.dart';
+import 'package:vector_graphics/vector_graphics.dart';
 
 @immutable
 abstract class AppImplementation<T extends Bloc, R extends NextcloudAppOptions> {
@@ -95,13 +95,15 @@ abstract class AppImplementation<T extends Bloc, R extends NextcloudAppOptions>
     final Color? color,
   }) =>
       Builder(
-        builder: (final context) => SizedBox.fromSize(
-          size: size,
-          child: SvgPicture.asset(
-            'assets/app.svg',
-            package: 'neon_$id',
-            colorFilter: ColorFilter.mode(color ?? Theme.of(context).colorScheme.primary, BlendMode.srcIn),
+        builder: (final context) => VectorGraphic(
+          width: size.width,
+          height: size.height,
+          colorFilter: ColorFilter.mode(color ?? Theme.of(context).colorScheme.primary, BlendMode.srcIn),
+          loader: AssetBytesLoader(
+            'assets/app.svg.vec',
+            packageName: 'neon_$id',
           ),
+          semanticsLabel: AppLocalizations.of(context).nextcloudLogo,
         ),
       );
 

packages/neon/neon/lib/src/widgets/nextcloud_logo.dart

@@ -1,18 +1,20 @@
 import 'package:flutter/widgets.dart';
-import 'package:flutter_svg/flutter_svg.dart';
 import 'package:neon/l10n/localizations.dart';
+import 'package:vector_graphics/vector_graphics.dart';
 
 class NextcloudLogo extends StatelessWidget {
   const NextcloudLogo({
     super.key,
   });
 
   @override
-  Widget build(final BuildContext context) => SvgPicture.asset(
-        'assets/logo_nextcloud.svg',
-        package: 'neon',
+  Widget build(final BuildContext context) => VectorGraphic(
         width: 100,
         height: 100,
+        loader: const AssetBytesLoader(
+          'assets/logo_nextcloud.svg.vec',
+          packageName: 'neon',
+        ),
         semanticsLabel: AppLocalizations.of(context).nextcloudLogo,
       );
 }

packages/neon/neon_files/pubspec.yaml

@@ -39,6 +39,7 @@ dev_dependencies:
     git:
       url: https://github.com/nextcloud/neon
       path: packages/neon_lints
+  vector_graphics_compiler: ^1.1.7
 
 flutter:
   uses-material-design: true

packages/neon/neon_news/pubspec.yaml

@@ -31,6 +31,7 @@ dev_dependencies:
     git:
       url: https://github.com/nextcloud/neon
       path: packages/neon_lints
+  vector_graphics_compiler: ^1.1.7
 
 flutter:
   uses-material-design: true

packages/neon/neon_notes/pubspec.yaml

@@ -31,6 +31,7 @@ dev_dependencies:
     git:
       url: https://github.com/nextcloud/neon
       path: packages/neon_lints
+  vector_graphics_compiler: ^1.1.7
 
 flutter:
   uses-material-design: true

packages/neon/neon_notifications/pubspec.yaml

@@ -25,6 +25,7 @@ dev_dependencies:
     git:
       url: https://github.com/nextcloud/neon
       path: packages/neon_lints
+  vector_graphics_compiler: ^1.1.7
 
 flutter:
   uses-material-design: true