make oneOf and anyOf throw at build time rather then on deserialization #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
force-pushed
the
fix/dynamite/some_ofs
branch
2 times, most recently
from
93899cd to
1649721
Compare
provokateurin
requested changes
Oct 25, 2023
packages/dynamite/dynamite_end_to_end_test/test/nested_ofs_test.dart
Outdated
Show resolved
Hide resolved
Leptopoda
force-pushed
the
fix/dynamite/some_ofs
branch
from
1649721 to
6817462
Compare
provokateurin
requested changes
Oct 25, 2023
packages/dynamite/dynamite_end_to_end_test/lib/nested_ofs.openapi.json
Outdated
Show resolved
Hide resolved
|
These weren't accidental but just the builder failing due to #1024 and I just didn't notice it. |
|
I think that particular one is by accident since you created a new property instead of setting the property to be required. All other ones are correct. |
Leptopoda
force-pushed
the
fix/dynamite/some_ofs
branch
from
6817462 to
dfc79b5
Compare
packages/dynamite/dynamite_end_to_end_test/lib/nested_ofs.openapi.dart
Outdated
Show resolved
Hide resolved
Leptopoda
force-pushed
the
fix/dynamite/some_ofs
branch
from
dfc79b5 to
3ab8f3e
Compare
provokateurin
approved these changes
Oct 29, 2023
…her then on deserialization Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
fix/dynamite/some_ofs
branch
from
3ab8f3e to
ec77029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correctly requires oneOf to only have one matching member.
Depends on #999 thus also blocked on the spec being corrected