test(nextcloud): Add checks to ensure that all available props are parsed #2558
+367
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…rsed Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
test/nextcloud/all-props-parsed
branch
from
4ae9f68
to
548176b
Compare
provokateurin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
==========================================
+ Coverage 28.66% 28.71% +0.04%
==========================================
Files 366 366
Lines 136296 136274 -22
==========================================
+ Hits 39076 39128 +52
+ Misses 97220 97146 -74
*This pull request uses carry forward flags. Click here to find out more. |
Leptopoda
reviewed
Oct 19, 2024
Comment on lines
+29
to
+56
| List<String> _getMultistatusPropNames(XmlElement root) { | ||
| return root.firstElementChild!.childElements | ||
| .singleWhere( | ||
| (node) => | ||
| node.name.local == 'propstat' && | ||
| node.childElements.singleWhere((node) => node.name.local == 'status').innerText.contains('200 OK'), | ||
| ) | ||
| .childElements | ||
| .singleWhere((node) => node.name.local == 'prop') | ||
| .childElements | ||
| .map((el) => '{${el.name.namespaceUri}}${el.name.local}') | ||
| .toList() | ||
| .sorted(); | ||
| } | ||
|
|
||
| Future<void> _expectAllPropsAreParsed(NextcloudTester tester, WebDavMultistatus result, PathUri uri) async { | ||
| final parsedProps = _getMultistatusPropNames(result.toXmlElement(namespaces: namespaces)); | ||
| expect(parsedProps, isNotEmpty); | ||
|
|
||
| final streamedResponse = await tester.client.webdav.httpClient.send(tester.client.webdav.propfind_Request(uri)); | ||
| expect(streamedResponse.statusCode, 207); | ||
| final rawResponse = await http.Response.fromStream(streamedResponse); | ||
|
|
||
| final expectedProps = _getMultistatusPropNames(XmlDocument.parse(rawResponse.body).rootElement); | ||
| expect(expectedProps, isNotEmpty); | ||
|
|
||
| expect(parsedProps, expectedProps); | ||
| } |
There was a problem hiding this comment.
I don't like this being here.
I'd rather have it be a Matcher from package:test_api and have it be located inside nextcloud_test.
There was a problem hiding this comment.
That seems like quite a lot of effort for this little thing that is only used twice, no?
| final parsedProps = _getMultistatusPropNames(result.toXmlElement(namespaces: namespaces)); | ||
| expect(parsedProps, isNotEmpty); | ||
|
|
||
| final streamedResponse = await tester.client.webdav.httpClient.send(tester.client.webdav.propfind_Request(uri)); |
There was a problem hiding this comment.
Do these calls need to be in the fixtures?
I'd rather have it not included.
There was a problem hiding this comment.
No, we can exclude them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to become a lot more useful when sabre-io/dav#1564 is merged and in a released Nextcloud version, as we are currently missing out on a lot of props when requesting all available props.