Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid using constant that is not available on 25 #1182

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: Avoid using constant that is not available on 25 #1182

merged 1 commit into from
Dec 15, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 15, 2023 •
edited
Loading

Fix #1177 for stable25

@juliusknorr
fix: Avoid using constant that is not available on 25
41eadab 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Dec 15, 2023
datenangebot
datenangebot approved these changes Dec 15, 2023
View reviewed changes
Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

Btw: I guess "FIXME" is also a keyword that gets tracked?
Otherwise I would "TODO" recommend as this might be tracked in most IDEs...

@juliusknorr
Copy link
Member Author

FIXME is also collected by phpstorm for example (together with TODO)

@juliusknorr juliusknorr merged commit a530f06 into main Dec 15, 2023
9 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/sciencemesh-constant-25 branch December 15, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenangebot datenangebot datenangebot approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Unable to Read Notes From Server After Update to 4.9
2 participants
@juliusknorr @datenangebot