Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to more standard CI pipelines #1389

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Move to more standard CI pipelines #1389

merged 7 commits into from
Oct 25, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 10, 2024 •
edited
Loading

  • chore: Move to more standard ci pipelines for eslint, stylelint, php-cs-fixer, psalm, info.xml
  • style: Apply php-cs-fixer changes
  • chore: Remove some deprecations in Application.php

Deprecation to file as issue to drop once we increase minimum supported versions:

INFO: DeprecatedMethod - lib/Migration/EditorHint.php:33:32 - The method OCP\IConfig::getAppValue has been marked as deprecated (see https://psalm.dev/001)
INFO: DeprecatedMethod - lib/Service/SettingsService.php:75:29 - The method OCP\IConfig::getAppValue has been marked as deprecated (see https://psalm.dev/001)
INFO: DeprecatedMethod - lib/Service/SettingsService.php:90:35 - The method OCP\IConfig::getAppValue has been marked as deprecated (see https://psalm.dev/001)
INFO: DeprecatedMethod - lib/Service/SettingsService.php:197:10 - The method OCP\Util::getVersion has been marked as deprecated (see https://psalm.dev/001)

Standardizing the phpunit test execution has been left out as it is more of an integration test that currently requires quite a lot of manual setup.

  • Adjust branch requirements to main branch once this PR is merged

@juliusknorr juliusknorr changed the title chore/ci updates Move to more standard CI pipelines Oct 10, 2024
@juliusknorr
chore: Move to more standard ci pipelines
53598df 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
style: Apply php-cs-fixer changes
49952d6 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
chore: Add psalm
41d141e 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
ci: Move linters to standard actions
2314eef 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
ci: Run psalm against lowest php version
4c0ddf7 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
chore: Cleanup application deprecations
4af90ec 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
ci: Add more checks
c4e44a4 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr mentioned this pull request Oct 11, 2024
Merged
@enjeck enjeck self-requested a review October 21, 2024 13:16
enjeck
enjeck approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@enjeck
Copy link
Contributor

enjeck commented Oct 24, 2024 •
edited
Loading

@juliusknorr Can you merge this (I can't, until #1388 is merged I think)? When we get this in, maybe the other dependabot PRs can now be auto-merged

@juliusknorr juliusknorr merged commit f8cd9cc into main Oct 25, 2024
28 checks passed
@juliusknorr juliusknorr deleted the chore/ci-updates branch October 25, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjeck enjeck enjeck approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter JuliaKirschenheuter is a code owner

Assignees
No one assigned
Labels
3. to review technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @enjeck