Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow photo upload on public-link shared album #1609

Open
g-work opened this issue Jan 24, 2023 · 7 comments
Open

Allow photo upload on public-link shared album #1609

g-work opened this issue Jan 24, 2023 · 7 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request feature: albums Related to the albums section

Comments

@g-work
Copy link

g-work commented Jan 24, 2023

When receiving a public link to an album, you can only view the content but not add photos yourself.
The [Hub 3 Announcement](Announcing Nextcloud Hub 3 - Brand New Design and Photos 2.0 with Editor and AI) says, “Futhermore, you can share the album with others using a public link so they can add their photos too.”.

How can this be achieved? I can't find the option.

To Reproduce
Steps to reproduce the behavior:

  1. Create an album
  2. Share it my public link
  3. Open link on other device and try to add photo
  4. Doesn't work. Only viewing is possible

Expected behavior
You should be able to "share the album with others using a public link so they can add their photos too.".

@g-work g-work added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Jan 24, 2023
@simonspa
Copy link

Indeed you are right with what the announcement promised. However, right now sharing is relatively basic and by no means as configurable as the one in Files (i.e. being able to select whether a public link will allow editing or addition.

I therefore think that a public link - as a default - should not allow uploading, and that everything that goes beyond this we should consider a feature request rather than a bug.

To solve your immediate problem: you can still share an actual folder with pictures, which would allow uploading by third parties if configured accordingly.

@simonspa simonspa added enhancement New feature or request and removed bug Something isn't working labels Jan 25, 2023
@simonspa simonspa changed the title Can't add photos to albums shared by public link Allow photo upload on public-link shared album Jan 25, 2023
@miaulalala
Copy link

miaulalala commented Apr 5, 2023

So the API for public albums doesn't allow adding anyway at the moment:
\OCA\Photos\Sabre\Album\PublicAlbumRoot::addFile throws a ForbiddenException.

So the button is dead code.

@ChristophWurst
Copy link
Member

So the button is dead code.

@artonge would it be okay to hide the button for now?

@artonge
Copy link
Collaborator

artonge commented Apr 24, 2023

There is no button, so nothing to hide.
However, some recent changes removed the 'Delete' button to reduce the confusion/expectation around public albums: #1749

@st3iny
Copy link
Member

st3iny commented Apr 24, 2023

There is a button when the shared album is empty.

add-button-before

@st3iny
Copy link
Member

st3iny commented Apr 24, 2023

I'll open a PR to fix this.

@Shoggomo
Copy link

Shoggomo commented Nov 4, 2023

Is this feature still being worked on? Would be nice, as the alternative is to create a folder for each album, which feels clunky.

@joshtrichards joshtrichards added the feature: albums Related to the albums section label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request feature: albums Related to the albums section
Projects
None yet
Development

No branches or pull requests

8 participants