Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide upload button on public album shares #1760

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Apr 24, 2023

Ref #1609

The button does not work because the backend is not done. Let's remove the button for now until it's fully implemented.

Before After
add-button-before grafik

@st3iny st3iny added bug Something isn't working 3. to review Waiting for reviews feature: albums Related to the albums section labels Apr 24, 2023
@st3iny st3iny requested a review from artonge April 24, 2023 11:49
@st3iny st3iny self-assigned this Apr 24, 2023
@st3iny st3iny added this to the Nextcloud 27 milestone Apr 24, 2023
@st3iny
Copy link
Member Author

st3iny commented Apr 24, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Apr 24, 2023
@st3iny
Copy link
Member Author

st3iny commented Apr 24, 2023

/backport to stable26

@st3iny st3iny requested a review from skjnldsv April 24, 2023 11:52
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 24, 2023
@st3iny st3iny force-pushed the fix/remove-public-add-button branch from e482a12 to 44dfd4e Compare April 24, 2023 12:55
@artonge artonge enabled auto-merge April 24, 2023 14:25
@artonge artonge merged commit 2e6c2d4 into master Apr 24, 2023
@artonge artonge deleted the fix/remove-public-add-button branch April 24, 2023 14:35
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request Pending backport by the backport-bot bug Something isn't working feature: albums Related to the albums section
Projects
Development

Successfully merging this pull request may close these issues.

3 participants