fix: open settings button #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
bug
ShGKme
changed the title
ShGKme
force-pushed
the
fix/show-settings-button
branch
from
c2ee50b to
28f5c16
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/show-settings-button
branch
from
28f5c16 to
cfe9479
Compare
|
/compile / amend |
ShGKme
changed the title
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
We probably should have this in the library as an alternative to NcAppNavigationSettings
JuliaKirschenheuter
approved these changes
Oct 23, 2023
Just a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of https://github.com/nextcloud/andy/issues/5
<NcAppNavigationItem>- renders as a list item<li>and is not allowed in the navigation footer without UL wrapper.But this part of the UI is not a list or navigation link, it only opens a modal.
This PR replaces navigation item with button.
The position of the icon is still a bit not in line, but IMO it should be fixed on the Nextcloud/vue side.
Also fixed new Vue 2.7
:deepselector usage.