Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new metadata API for providers #2104

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Use new metadata API for providers #2104

merged 3 commits into from
Nov 9, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Oct 25, 2023 •
edited
Loading

@artonge artonge self-assigned this Oct 25, 2023
@artonge artonge added enhancement New feature or request php PHP related ticket 2. developing Work in progress labels Oct 25, 2023
@artonge artonge added this to the Nextcloud 28 milestone Oct 25, 2023
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from 6bbd1da to bfc41f0 Compare October 26, 2023 06:51
@artonge artonge mentioned this pull request Oct 26, 2023
Closed
29 tasks
@artonge artonge changed the title Use new metadata API Use new metadata API for providers Oct 26, 2023
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from bfc41f0 to 2919715 Compare October 26, 2023 11:41
@artonge artonge requested a review from skjnldsv as a code owner October 26, 2023 11:41
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from 2919715 to f1832b5 Compare October 26, 2023 16:13
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from 8a864db to c6930e3 Compare November 2, 2023 15:06
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@artonge artonge mentioned this pull request Nov 7, 2023
Merged
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from c6930e3 to c902451 Compare November 8, 2023 11:17
artonge
artonge commented Nov 8, 2023
View reviewed changes
lib/Sabre/PropFindPlugin.php Outdated Show resolved Hide resolved
lib/Service/MediaPlaceManager.php Outdated Show resolved Hide resolved
ArtificialOwl
ArtificialOwl approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from c902451 to 9f9b998 Compare November 8, 2023 12:29
artonge
artonge commented Nov 8, 2023
View reviewed changes
lib/DB/Place/PlaceMapper.php Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make more use of IFilesMetadataManager
  • Delete methods that are not useful anymore

@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch 5 times, most recently from ebb3654 to 83466f3 Compare November 8, 2023 13:25
ArtificialOwl
ArtificialOwl approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back-end is 👍

@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch 2 times, most recently from aea50e3 to b733758 Compare November 9, 2023 10:50
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from e08724d to 303ee16 Compare November 9, 2023 11:43
@artonge artonge enabled auto-merge November 9, 2023 11:49
@artonge
Use new metadata API for providers
a87c19e 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Update nextcloud/ocp
084d748 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch 2 times, most recently from 392ff27 to c02e567 Compare November 9, 2023 13:44
@artonge
Fix psalm
52d0983 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/use_new_metadata_api branch from c02e567 to 52d0983 Compare November 9, 2023 13:51
@artonge artonge merged commit 03ea178 into master Nov 9, 2023
32 of 33 checks passed
@artonge artonge deleted the artonge/feat/use_new_metadata_api branch November 9, 2023 14:06
@ShGKme ShGKme linked an issue Nov 9, 2023 that may be closed by this pull request
Photos app breaks PROPFIND #2116
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv left review comments

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

Assignees

@artonge artonge

Labels
2. developing Work in progress enhancement New feature or request php PHP related ticket
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Photos app breaks PROPFIND
3 participants
@artonge @ArtificialOwl @skjnldsv