Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vue to 8.0.0-beta.9 #2111

Merged
merged 4 commits into from
Nov 1, 2023
Merged

update vue to 8.0.0-beta.9 #2111

merged 4 commits into from
Nov 1, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 31, 2023 •
edited
Loading

@szaimen szaimen added dependencies Pull requests that update a dependency file 2. developing Work in progress labels Oct 31, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Oct 31, 2023
@szaimen
update vue to 8.0.0-beta.9
2563e7b 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/update-vue-beta.9 branch from 41a3991 to 2563e7b Compare October 31, 2023 14:25
@szaimen
Copy link
Contributor Author

szaimen commented Oct 31, 2023

/compile

@szaimen szaimen mentioned this pull request Oct 31, 2023
Closed
nextcloud-command and others added 2 commits October 31, 2023 15:01
@nextcloud-command
chore(assets): Recompile assets
6e216fa 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
fix ESlint
18cd990 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Oct 31, 2023

/compile

@szaimen szaimen marked this pull request as ready for review October 31, 2023 15:27
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 31, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Oct 31, 2023

/compile

@nextcloud-command
chore(assets): Recompile assets
6a9802c 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
Pytal
Pytal reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to resolve the 2 points in the linked issue @szaimen ?

@szaimen
Copy link
Contributor Author

szaimen commented Nov 1, 2023 •
edited
Loading

Does not seem to resolve the 2 points in the linked issue @szaimen ?

Yes, it only fixes the toggle so that it opens again after closing

@szaimen szaimen enabled auto-merge November 1, 2023 17:22
@szaimen szaimen merged commit 5edd0b7 into master Nov 1, 2023
23 checks passed
@szaimen szaimen deleted the enh/noid/update-vue-beta.9 branch November 1, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@artonge artonge Awaiting requested review from artonge

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[BITV] Fix left sidebar from a11y perspective
3 participants
@szaimen @Pytal @nextcloud-command