Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Add unique DOM identifiers for nav entries #2118

Merged
merged 1 commit into from
Nov 15, 2023
Merged

enh: Add unique DOM identifiers for nav entries #2118

merged 1 commit into from
Nov 15, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 10, 2023

Check DOM:

[...document.querySelectorAll('[data-id-app-nav-item]')].map(el => el.dataset.idAppNavItem)

@Pytal Pytal added the 3. to review Waiting for reviews label Nov 10, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Nov 10, 2023
@Pytal Pytal requested review from juliusknorr and artonge November 10, 2023 19:19
@Pytal Pytal self-assigned this Nov 10, 2023
@juliusknorr
Copy link
Member

/backport to stable27

@juliusknorr
Copy link
Member

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Nov 10, 2023
@juliusknorr
Copy link
Member

/backport to stable25

@Pytal
Copy link
Member Author

Pytal commented Nov 10, 2023

/backport to stable24

@Pytal

This comment was marked as outdated.

Sign in to view
@blizzz blizzz mentioned this pull request Nov 13, 2023
Merged
@blizzz blizzz mentioned this pull request Nov 14, 2023
Merged
@Pytal Pytal force-pushed the enh/app-nav-data-id branch 2 times, most recently from fa48fe0 to cdb9513 Compare November 15, 2023 17:36
@Pytal

This comment was marked as outdated.

Sign in to view
@Pytal
Copy link
Member Author

Pytal commented Nov 15, 2023

/compile amend /

@Pytal @nextcloud-command
enh: Add unique DOM identifiers for nav entries
d8f4124 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 15, 2023
@Pytal Pytal merged commit 44ec2b5 into master Nov 15, 2023
23 checks passed
@Pytal Pytal deleted the enh/app-nav-data-id branch November 15, 2023 18:01
This was referenced Nov 15, 2023
Merged
Merged
Merged
Merged
@Pytal Pytal removed the backport-request Pending backport by the backport-bot label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @juliusknorr @artonge