Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata: fix crash when datetime has invalid format #2128

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

pulsejet
Copy link
Member

For any reason if the date time is not in the correct format, the entire scan process crashed.

For any reason if the date time is not in the correct format, the
entire scan process crashed.

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@pulsejet pulsejet requested a review from artonge November 14, 2023 03:27
@pulsejet pulsejet added bug Something isn't working 3. to review Waiting for reviews labels Nov 14, 2023
@pulsejet pulsejet added this to the Nextcloud 28 milestone Nov 14, 2023
@artonge
Copy link
Collaborator

artonge commented Nov 14, 2023

Thanks for testing and for the correction ❤️
Did you have any issue for the second fix? As the date format is supposed to match the regexp, I would think that there couldn't be any error. In any case, let's keep it :)

@pulsejet
Copy link
Member Author

As the date format is supposed to match the regexp, I would think that there couldn't be any error.

There might be. For example PXL_99999999_999999.JPG would match the regex but I don't know if PHP can parse this correctly.

@artonge artonge merged commit cd41849 into master Nov 14, 2023
28 checks passed
@artonge artonge deleted the pulsejet/crash-fix-1 branch November 14, 2023 16:53
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants