Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Backwards photos tabulation #2129

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix(a11y): Backwards photos tabulation #2129

merged 2 commits into from
Nov 15, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 15, 2023

Summary

  • Fix tab navigation on photos

@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews accessibility labels Nov 15, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Nov 15, 2023
@Pytal Pytal self-assigned this Nov 15, 2023
@Pytal

This comment was marked as outdated.

Sign in to view
@nextcloud-command nextcloud-command force-pushed the enh/a11y/backwards-kb-tab branch from 1eadda7 to 4497980 Compare November 15, 2023 02:12
@blizzz blizzz mentioned this pull request Nov 15, 2023
Merged
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

artonge
artonge approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was on purpose, my bad haha

@Pytal
fix(a11y): Backwards photos tabulation
a700c74 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y/backwards-kb-tab branch from 4497980 to b6221e4 Compare November 15, 2023 18:05
@Pytal
Copy link
Member Author

Pytal commented Nov 15, 2023

/compile amend /

@Pytal @nextcloud-command
chore: compile assets
5f378d6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/a11y/backwards-kb-tab branch from b6221e4 to 5f378d6 Compare November 15, 2023 18:10
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 15, 2023
@Pytal Pytal merged commit 9c205b0 into master Nov 15, 2023
23 checks passed
@Pytal Pytal deleted the enh/a11y/backwards-kb-tab branch November 15, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug Something isn't working
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @JuliaKirschenheuter @artonge @ShGKme